Skip to content

Conversation

@not-matthias
Copy link
Member

No description provided.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 9, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing cod-1963-codspeed-cpp-starts-valgrind-twice (56e942a) with main (5ef9067)

Summary

✅ 192 untouched benchmarks

Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is handled by the iterator impl right ?

Could you add a tiny bit more context as to what this fixes and why we're fixing this ?

@not-matthias
Copy link
Member Author

This is handled by the iterator impl right ?

yes, we're already starting/stopping in the State which is used in the benchmark loop.

Could you add a tiny bit more context as to what this fixes and why we're fixing this ?

The main issue is that in simulation mode, we were calling measurement_start/stop twice. For now, this didn't cause any issues because we're clearing the events when starting, and nothing happens when stopping.

I believe we should remove it just to prevent errors later on, in case we're extending the valgrind implementation or when reusing it for memory profiling for example.

@not-matthias not-matthias merged commit 56e942a into main Jan 12, 2026
25 checks passed
@not-matthias not-matthias deleted the cod-1963-codspeed-cpp-starts-valgrind-twice branch January 12, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants